Base branch for CI/env fixes #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiquesydow
added
bug
T008/10/15/16/18/20: AttributeError: module 'numpy' has no attribute 'typeDict'
T011/12: Remove pinned `jsonschema` from env
This was
linked to
issues
Dec 27, 2022
T018: Remove nbval check for complex cell output
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
T019: Change `atom.unit` to `atom.units`
This was
linked to
issues
Dec 30, 2022
T021/22: Run under global environment
3 tasks
|
CI is passing for all notebooks except for T019, which we will tackle in a follow-up PR, see #308. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current
teachopencaddhas a couple of dependency conflicts and deps-unrelatedpytestfails.This base branch shall be used to get a fully passing CI, while fixing all the different bits and pieces in smaller PRs.
Todos
numpy<1.24and unpintensorflow; do not test T021/22 and deal with it later (see below)jsonschemafrom env #297jsonschemafrom environments #152tensorflowimports? #265fontconfigbecause macOS dylib version changed despite fontconfig version not changing conda-forge/fontconfig-feedstock#54 seems fixed?Notes: After this PR's merge
...continue with TODOs in #312
Status