Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile #323

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

isarrider
Copy link
Contributor

Define target build dir as tmpfs (makes build a little faster)
Be more specific by using FROM alpine:latest instead only FROM alpine

Define target build dir as tmpfs (makes build a little faster)
Be more specific by using FROM alpine:latest instead only FROM alpine
@SchumacherFM
Copy link

Can this be please merged to speed up docker build @andig ?

@andig
Copy link
Contributor

andig commented Mar 27, 2024

Does this have any measurable effect? Does layer csching still work?

@SchumacherFM
Copy link

$ time docker buildx build --platform linux/arm64 -t ghcr.io/xxxxxxxxxx/mbmd:latest .
This PR

real	11m48.745s
user	0m2.571s
sys	0m2.225s

Without these changes:

real	10m55.284s
user	0m2.364s
sys	0m1.871s

OMG 🤣 - IMHO you can close this PR without merging. Sorry for bothering you.

@isarrider
Copy link
Contributor Author

I cant remember the time difference but did you bench on sth with a very slow storage like a SD-Card?

@SchumacherFM
Copy link

MacBook Pro 13-inch, 2017 with Docker Desktop

@isarrider
Copy link
Contributor Author

Well - when there is a fast SSD in -> of course no advantage
(besides not abusing the SSD Write cycles)
I use it on my Rock 5 with a slow SD Card...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants