Use GitHub API to retrieve latest release information. #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were requesting `https://volta.sh/latest-version` (which is what the `curl` based installer workflow documented on the homepage does). Unfortunately, we end up getting `ECONNREFUSED` from the service we use to host https://volta.sh. This replaces the usage of `https://volta.sh/latest-version` with directly using GitHub's API at `https://api.github.com/repos/volta-cli/volta/releases/latest`. The new system is setup to retry 3 times **and** threads through the current $GITHUB_TOKEN (which should avoid throttling issues).
rwjblue
force-pushed
the
get-latest-from-gh-api
branch
from
e2aa4cb
to
c2f4a5b
Compare
scalvert
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were requesting
https://volta.sh/latest-version(which is what thecurlbased installer workflow documented on the homepage does). Unfortunately, we end up gettingECONNREFUSEDfrom the service we use to host https://volta.sh.This replaces the usage of
https://volta.sh/latest-versionwith directly using GitHub's API athttps://api.github.com/repos/volta-cli/volta/releases/latest. The new system is setup to retry 3 times and threads through the current $GITHUB_TOKEN (which should avoid throttling issues).