-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace openssl-version
configuration with variant
#102
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer that variant
be everything after volta-${version}
. So a valid value would be linux-openssl-rhel
for example.
We should also update openssl-version
to allow specifying rhel
/RHEL
specifically (so you could just say that too).
I was also thinking along similar lines. It felt odd to have both |
bb7f60e
to
bb44087
Compare
I split out the actions-docs part into #104 |
Co-authored-by: Robert Jackson <me@rwjblue.com>
04c0244
to
50fafc2
Compare
openssl-version
configuration with variant
Co-authored-by: Robert Jackson <me@rwjblue.com>
This PR adds a new
variant
input, which allows consumers to further qualify the version of Volta to target, specifically in the case of RHEL installations.