Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace openssl-version configuration with variant #102

Merged
merged 13 commits into from
Sep 7, 2022

Conversation

scalvert
Copy link
Contributor

This PR adds a new variant input, which allows consumers to further qualify the version of Volta to target, specifically in the case of RHEL installations.

Copy link
Collaborator

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer that variant be everything after volta-${version}. So a valid value would be linux-openssl-rhel for example.

We should also update openssl-version to allow specifying rhel/RHEL specifically (so you could just say that too).

@scalvert
Copy link
Contributor Author

scalvert commented Sep 1, 2022

I was also thinking along similar lines. It felt odd to have both openssl-version and variant when they're both so closely related. It may make sense instead to just consolidate them, and allow users to do what you described above. WDYT?

@scalvert scalvert force-pushed the variant-input branch 2 times, most recently from bb7f60e to bb44087 Compare September 1, 2022 19:53
@rwjblue rwjblue mentioned this pull request Sep 2, 2022
@rwjblue
Copy link
Collaborator

rwjblue commented Sep 2, 2022

I split out the actions-docs part into #104

action.yml Outdated Show resolved Hide resolved
dist/index.js Outdated Show resolved Hide resolved
@rwjblue rwjblue changed the title Allow specifying variant input to support RHEL installs Replace openssl-version configuration with variant Sep 7, 2022
src/installer.ts Outdated Show resolved Hide resolved
Co-authored-by: Robert Jackson <me@rwjblue.com>
@rwjblue rwjblue merged commit f8549fc into volta-cli:master Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants