Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for self-hoster runners (instead of relying on RUNNER_TEMP) #110

Merged
merged 2 commits into from
Oct 3, 2022

Conversation

jeevcat
Copy link
Contributor

@jeevcat jeevcat commented Sep 22, 2022

On self-hosted runners, the shims would be set up as symlinks to files in the RUNNER_TEMP directory. This directory is cleared after each run, while the tools cache is retained. This means subsequent runs would fail.

Changes:

  • Setup volta using the cached tool path instead of the RUNNER_TEMP path
  • Use import.meta.url isntead of __dirname

@rwjblue
Copy link
Collaborator

rwjblue commented Sep 26, 2022

I pushed a couple of minor tweaks (including fixing the issue with npm test RE: the import.meta change ).

@rwjblue rwjblue added the bug Something isn't working label Sep 26, 2022
@rwjblue
Copy link
Collaborator

rwjblue commented Sep 26, 2022

src/matchers.ts:5:28 - error TS1343: The 'import.meta' meta-property is only allowed when the '--module' option is 'es2020', 'es2022', 'esnext', 'system', 'node16', or 'nodenext'.

5   matchersPath = path.join(import.meta.url, '..', 'matchers')

Still failing due to this 😢. I'll have to dig into it a bit later.

jeevcat and others added 2 commits October 3, 2022 11:57
I prefer to do this upon merge / release (not as part of the PR itself)
@rwjblue
Copy link
Collaborator

rwjblue commented Oct 3, 2022

I rolled back the import.meta.url changes for now (in order to land the other TEMP fixes)

@rwjblue rwjblue changed the title Fix for self-hoster runners Fix for self-hoster runners (instead of relying on RUNNER_TEMP) Oct 3, 2022
@rwjblue rwjblue merged commit cdf729c into volta-cli:master Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants