Fall back to downloading latest version from volta.sh on rate-limit #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GitHub.com server returns a 403 or 429 status code in case of rate- limiting. This commit adds a check for those status codes and tries to fetch the latest volta version from https://volta.sh/latest-version instead. The implementation is somewhat analog to how setup-node is implemented: - https://github.com/actions/setup-node/blob/9f3a02bbd17adc05b078145bb8f676c84be77e89/src/installer.ts#L109-L129 Fixes: volta-cli#108
rwjblue
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GitHub.com server returns a 403 or 429 status code in case of rate- limiting.
This commit adds a check for those status codes and tries to fetch the latest volta version from https://volta.sh/latest-version instead.
The implementation is somewhat analog to how setup-node is implemented:
Fixes: #108