Ensure specifying a node-version updates the pinned node.
#24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
force-pushed
the
specifying-version-on-pinned-projected
branch
7 times, most recently
from
42321f3
to
3aca236
Compare
Leverages the ability to checkout specific branches in `action/checkout@v2` to checkout the main repo (`volta-cli/action`) into a subfolder (`./action`) and an orphaned branch with only a `package.json` that has pinned node/yarn versions into the working directory root. This allows us to test the action as if it were _inside_ a normal project setting (aka the actions own setup does not break the CI test).
rwjblue
force-pushed
the
specifying-version-on-pinned-projected
branch
from
3aca236
to
7d76f6f
Compare
|
Thanks for the fix here! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
volta pinwhen within a Node project)Fixes #21