Ensure all test scripts fail on uncaught exceptions. #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is failing (I think) because volta removes itself from |
rwjblue
force-pushed
the
fail-on-uncaught-exceptions
branch
12 times, most recently
from
6915a1e
to
067558d
Compare
rwjblue
force-pushed
the
fail-on-uncaught-exceptions
branch
from
067558d
to
ad429c4
Compare
rwjblue
commented
Oct 6, 2020
Comment on lines
+45
to
+46
| - run: volta install node@10.17.0 yarn@1.19.0 | ||
| - run: tests/check-version.sh 'node' 'v10.17.0' |
There was a problem hiding this comment.
--unhandled-rejections flag was added in 10.17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.