Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to npm@8 #46

Merged
merged 2 commits into from
Aug 17, 2022
Merged

Update to npm@8 #46

merged 2 commits into from
Aug 17, 2022

Conversation

rwjblue
Copy link
Collaborator

@rwjblue rwjblue commented Oct 22, 2020 •
edited
Loading

  • Pin node@16 and npm@8 versions for local development.
  • Update package-lock.json for npm@8.

@rwjblue
Copy link
Collaborator Author

rwjblue commented Oct 22, 2020

Hmm. Looks like we can't pin in the repo because it causes that pinned value to "win" in our local tests. We probably need to refactor the tests (again 😩) to use something akin to the test job for test-specified-node-yarn-overrides-pinned-versions.

@rwjblue rwjblue marked this pull request as draft October 22, 2020 14:19
@rwjblue rwjblue force-pushed the re-roll-package-lock branch 2 times, most recently from 10f546f to a690954 Compare August 12, 2022 18:02
@rwjblue rwjblue changed the title Update to npm@7. Update to npm@8 Aug 12, 2022
@rwjblue rwjblue force-pushed the re-roll-package-lock branch 2 times, most recently from fc54143 to 1005ba6 Compare August 17, 2022 18:13
@rwjblue rwjblue marked this pull request as ready for review August 17, 2022 18:33
@rwjblue rwjblue merged commit 7bed421 into master Aug 17, 2022
@rwjblue rwjblue deleted the re-roll-package-lock branch August 17, 2022 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rwjblue