Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for running the tests to the README. #183

Merged
merged 1 commit into from
Oct 31, 2018
Merged

Add documentation for running the tests to the README. #183

merged 1 commit into from
Oct 31, 2018

Conversation

rwjblue
Copy link
Contributor

@rwjblue rwjblue commented Oct 22, 2018

This adds the current test command to the README while we work on a better solution over in #168.

README.md Outdated
To run the tests in this repo, run the following:

```
cargo test --features mock-network
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be cargo test --all --features mock-network, to include all the unit tests from the sub-crates in this project

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that, thank you for pointing out the correct command!

README.md Outdated
To run the tests in this repo, run the following:

```
cargo test --features mock-network
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cargo test --features mock-network
cargo test --all --features mock-network

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👼 trying out the new feature.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, they didn't send me a notification for the suggested fix 😕 and I clobbered it...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh that's an interesting new thing!

@mikrostew mikrostew merged commit 1732f68 into volta-cli:master Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants