Remotepi: Extended localization support et al. #187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added modal showing up if a reboot is required; added localization support for modals, toast messages etc.
Adjustments for extended localization support
Update version number to 1.1.0
Adding strings for toast messages and "reboot required" user modal; minor corrections.
Adding strings for toast messages and "reboot required" user modal.
Fix/workaround: The localization files are scanned only when Volumio starts and the plugin is already enabled. Therefore after just installing and enabling the plugin or after booting Volumio with the plugin in disabled state and then enabling it had the effect that localized strings for toasts etc. were not available (toasts did not show up at all then). Now on every start of the plugin the method "self.commandRouter.loadI18nStrings()" gets called which reads the necessary strings.
Change in method "writeBootStr" in order to avoid unnecessary write operations on /boot/config.txt
gvolt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits 04/2018:
Commits 05.09.2018:
Commits 20.11.2018: