Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Precision in edge interpolation and offsetting #44

Closed
voneiden opened this issue May 9, 2023 · 3 comments · Fixed by #48
Closed

Precision in edge interpolation and offsetting #44

voneiden opened this issue May 9, 2023 · 3 comments · Fixed by #48
Assignees
@voneiden
Labels
quality Achievement unlocked: Shoe polish

Comments

@voneiden
Copy link
Owner

voneiden commented May 9, 2023

Currently hardcoded, should respect Job.precision
@voneiden voneiden added the quality Achievement unlocked: Shoe polish label May 9, 2023
@voneiden voneiden self-assigned this May 9, 2023
@voneiden voneiden mentioned this issue May 9, 2023
Open
@giannissc
Copy link
Contributor

Precision is also related to the units selected so maybe we could consolidate them?

@voneiden
Copy link
Owner Author

Yeah, that can be a separate issue. The current default of 3 decimals is 0.001" or 0.001 mm depending on the unit. For metric it's probably a bit excessive for a default. For imperial it's probably pretty good.

@voneiden
Copy link
Owner Author

#47

@voneiden voneiden mentioned this issue May 10, 2023
Merged
@voneiden voneiden mentioned this issue May 18, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@voneiden voneiden

Labels
quality Achievement unlocked: Shoe polish
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Observe precision in interpolation and clipper voneiden/cq-cam
2 participants
@voneiden @giannissc