Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observe precision in interpolation and clipper #48

Merged
merged 1 commit into from
May 12, 2023
Merged

Conversation

voneiden
Copy link
Owner

Closes #44

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Merging #48 (a8222fd) into unstable (10c75da) will increase coverage by 0.09%.
The diff coverage is 89.28%.

❗ Current head a8222fd differs from pull request most recent head 1cc4f55. Consider uploading reports for the commit 1cc4f55 to get more accurate results

@@             Coverage Diff              @@
##           unstable      #48      +/-   ##
============================================
+ Coverage     83.05%   83.15%   +0.09%     
============================================
  Files            36       37       +1     
  Lines          2555     2576      +21     
============================================
+ Hits           2122     2142      +20     
- Misses          433      434       +1     
Impacted Files Coverage Δ
src/cq_cam/utils/interpolation.py 40.25% <50.00%> (+1.07%) ⬆️
src/cq_cam/routers.py 71.42% <60.00%> (+0.18%) ⬆️
src/cq_cam/fluent.py 87.19% <100.00%> (ø)
src/cq_cam/operations/pocket.py 84.55% <100.00%> (ø)
src/cq_cam/utils/geometry_op.py 85.13% <100.00%> (ø)
src/cq_cam/utils/tests/test_clipper_precision.py 100.00% <100.00%> (ø)

... and 9 files with indirect coverage changes

@voneiden voneiden force-pushed the precision branch 2 times, most recently from 2b4cf9c to d19bc20 Compare May 12, 2023 11:08
@voneiden voneiden marked this pull request as ready for review May 12, 2023 11:08
@sonarcloud
Copy link

sonarcloud bot commented May 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@voneiden voneiden merged commit 28cb3a8 into unstable May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Precision in edge interpolation and offsetting
1 participant