Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use export type #251

Merged
merged 2 commits into from
Nov 22, 2024
Merged

chore: use export type #251

merged 2 commits into from
Nov 22, 2024

Conversation

bekatru
Copy link
Contributor

@bekatru bekatru commented Nov 19, 2024

Added a type to exports in the index file to support enabled isolatedModules flag.

@vonovak
Copy link
Owner

vonovak commented Nov 19, 2024

@bekatru thank you, can you please update the failing snapshot?

@bekatru
Copy link
Contributor Author

bekatru commented Nov 21, 2024

@vonovak
Having hard times understanding what's going on.
Seems like these files are not being generated requires-android.txt
requires-ios.txt. and yarn requires-ios/android is failing inside the example directory.

Could you give me a hint?

@vonovak vonovak changed the title Typescript misc chore: use export type Nov 22, 2024
@vonovak vonovak merged commit 1a9dd68 into vonovak:master Nov 22, 2024
3 checks passed
@vonovak
Copy link
Owner

vonovak commented Nov 22, 2024

Hi! I hope you don't mind I fixed it; I think the only issue is that you didn't run yarn in the example folder, which is required here.

Thank you for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants