Add a switch on the bucket policy #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you manage the bucket policy for example for CRR or SRR already outside the module, you need to be able to handle the policy without the module. Signed-off-by: Arne-Kristian Hingst <arne@hingst.it>
Allow to disable the bucket policy
custom_origins is an object variable that can specify additional origins apart from the default bucket. On top of that, to support "routing" the ordered cache behavior was introduced. Note that the implementation was based on CloudPosse's CloudFront module Ref: https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/
Adding Forwarded values to custom_origins using the default values from variables.
Adding Custom origins and behaviors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our use case we need to change the bucket policy outside this module. There was no easy way to do this with the actual module.
We added a switch with
enable_bucket_policydefaulting to be true.Hope this fits into the mainstream module.