Skip to content

Implement filter for SequenceArray #4799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AdamGS merged 1 commit into from
Sep 30, 2025
Merged

Implement filter for SequenceArray #4799

AdamGS merged 1 commit into from
Sep 30, 2025

Conversation

@AdamGS
Copy link
Contributor

@AdamGS AdamGS commented Sep 30, 2025

Like take, this potentially has much temporary memory footprint.

@AdamGS
Implement filter for SequenceArray
734843a 
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS added performance Release label indicating an improvement to performance chore Release label indicating a trivial change labels Sep 30, 2025
a10y
a10y approved these changes Sep 30, 2025
View reviewed changes
Copy link
Contributor

@a10y a10y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice to avoid the intermediate allocation

@codecov
Copy link

codecov bot commented Sep 30, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 77.77778% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.52%. Comparing base (ff4fd2f) to head (734843a).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
encodings/sequence/src/compute/filter.rs 77.77% 4 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AdamGS AdamGS merged commit b7507b1 into develop Sep 30, 2025
45 of 46 checks passed
@AdamGS AdamGS deleted the adamg/filter-sequence-arrays branch September 30, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@a10y a10y a10y approved these changes

@joseph-isaacs joseph-isaacs Awaiting requested review from joseph-isaacs

Assignees

No one assigned

Labels

chore Release label indicating a trivial change performance Release label indicating an improvement to performance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AdamGS @a10y