Arc<Box<_>> a struct array's children #4989
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamGS
force-pushed
the
adamg/arc-box-array-ref
branch
from
5b01ddf to
bd2b5eb
Compare
github-actions
bot
removed
the
action/benchmark-sql
gatesn
reviewed
Oct 17, 2025
| pub fn new( | ||
| names: FieldNames, | ||
| fields: impl Into<Arc<[ArrayRef]>>, | ||
| fields: impl Into<Arc<Box<[ArrayRef]>>>, |
Contributor
There was a problem hiding this comment.
Either way, I would strongly prefer this to not be an impl Into and have the caller invoke .into()!
Contributor
Author
There was a problem hiding this comment.
yeah if this shows any promise I'll create a type here, we should really stop having functions that take these complex Intos
CodSpeed Performance ReportMerging #4989 will degrade performances by 61.74%Comparing Summary
Benchmarks breakdown
|
Contributor
Benchmarks: FineWeb NVMeSummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb S3Summary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: Clickbench on NVMESummary
Detailed Results Table
|
Contributor
Author
|
I really want to believe these benchmark results, but this is the second PR I saw in the past ~hour that shows a 40% improvement in clickbench q0 |
Contributor
Benchmarks: Statistical and Population GeneticsSummary
Detailed Results Table
|
AdamGS
force-pushed
the
adamg/arc-box-array-ref
branch
from
bd2b5eb to
df66020
Compare
github-actions
bot
removed
the
action/benchmark-sql
Contributor
Author
|
seems like the varbinview change regressed performance? I'll try to better separate it out to make it easier to figure out. |
AdamGS
force-pushed
the
adamg/arc-box-array-ref
branch
from
3593379 to
5cad79b
Compare
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
AdamGS
force-pushed
the
adamg/arc-box-array-ref
branch
from
2c94b2b to
2ad7406
Compare
github-actions
bot
removed
the
action/benchmark-sql
github-actions
bot
removed
the
action/benchmark-sql
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
AdamGS
force-pushed
the
adamg/arc-box-array-ref
branch
from
de0c1b9 to
374da1b
Compare
gatesn
requested changes
Oct 21, 2025
Contributor
gatesn
left a comment
gatesn
left a comment
There was a problem hiding this comment.
Discussed offline, we will try to find a lint that checks for unnecessary vec![..].into() when [...].into() would be sufficient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The thinking here is that
Vec<T>->Arc<[T]>requires copying the data, butVec<T>->Box<[T]>does not.This PR also introduces a new struct named
StructArrays(really need a different name) that wraps the children to make the API a bit more ergonomic and less dependent on the actual pointers it uses.The benchmarks results are really confusing, but there's some positive trend (potentially just wishful thinking).