Stop enabling pyo3/extension-modules by default
#4992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamGS
force-pushed
the
adamg/clean-py-build
branch
from
3a8c093 to
df12e73
Compare
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
AdamGS
force-pushed
the
adamg/clean-py-build
branch
from
aa04580 to
36249e6
Compare
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
AdamGS
commented
Oct 19, 2025
|
|
||
| # Environment variables for PyO3. Ensures reproducible builds and avoids spurious recompilations. | ||
| [env] | ||
| PYO3_PYTHON = { value = ".venv/bin/python", relative = true, force = true } |
Contributor
Author
There was a problem hiding this comment.
We saw in Spiral that this behave nicely now, setting it globally makes a bunch of build processes have unintended dependency on this path and general setup, which is not always desirable.
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
robert3005
approved these changes
Oct 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this section the pyo3's docs. We already enable it when building the whl with maturin.