Skip to content

Conversation

@AdamGS
Copy link
Contributor

@AdamGS AdamGS commented Oct 20, 2025

dependencies must be actually released versions, otherwise we can't release ourselves.

@AdamGS AdamGS requested a review from joseph-isaacs October 20, 2025 10:32
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS force-pushed the adamg/move-fastlanes-to-released-version branch from 3e8371c to 6b214b6 Compare October 20, 2025 10:32
@AdamGS AdamGS added the chore Release label indicating a trivial change label Oct 20, 2025
@joseph-isaacs
Copy link
Contributor

Sorry this was me I forgot to update

@AdamGS AdamGS enabled auto-merge (squash) October 20, 2025 10:36
@AdamGS AdamGS merged commit fd130ec into develop Oct 20, 2025
45 of 46 checks passed
@AdamGS AdamGS deleted the adamg/move-fastlanes-to-released-version branch October 20, 2025 10:43
@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.28%. Comparing base (a5da09c) to head (6b214b6).
⚠️ Report is 2 commits behind head on develop.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@robert3005
Copy link
Contributor

I assumed renovate would move us back to released version but it would just bump git commits

@AdamGS
Copy link
Contributor Author

AdamGS commented Oct 20, 2025

I think that theoretically you could configure it to do that, it picks an "update strategy" for each dependency and I assume we can tell it to always prefer a real version over a digest for cargo ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Release label indicating a trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants