Skip to content

Conversation

@gatesn
Copy link
Contributor

@gatesn gatesn commented Oct 23, 2025

No description provided.

Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn requested a review from connortsui20 October 23, 2025 19:16
@gatesn gatesn added the feature Release label indicating a new feature or request label Oct 23, 2025
@gatesn gatesn enabled auto-merge (squash) October 23, 2025 19:16
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 23, 2025

CodSpeed Performance Report

Merging #5054 will degrade performances by 43.37%

Comparing ngates/vortex-compute (9eebdc5) with develop (6b8df0c)

Summary

⚡ 2 improvements
❌ 7 regressions
✅ 1300 untouched
🆕 5 new

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
bitwise_and_arrow_buffer[1024] 3.5 µs 6.2 µs -43.37%
bitwise_not_vortex_buffer[2048] 5.3 µs 4.7 µs +11.76%
🆕 bitwise_not_vortex_buffer_mut[1024] N/A 1.2 µs N/A
🆕 bitwise_not_vortex_buffer_mut[128] N/A 1.2 µs N/A
🆕 bitwise_not_vortex_buffer_mut[16384] N/A 2.6 µs N/A
🆕 bitwise_not_vortex_buffer_mut[2048] N/A 1.3 µs N/A
🆕 bitwise_not_vortex_buffer_mut[65536] N/A 5.7 µs N/A
bitwise_or_arrow_buffer[2048] 3.7 µs 6.3 µs -40.98%
bitwise_or_vortex_buffer[2048] 4.6 µs 5.5 µs -15.98%
BooleanBuffer>, 128] 5.5 µs 3.7 µs +47.29%
set_indices_arrow_buffer[128] 1 µs 1.2 µs -14.78%
set_indices_vortex_buffer[128] 1.1 µs 1.3 µs -15.66%
slice_arrow_buffer[16384] 1.9 µs 2.1 µs -10.36%
slice_vortex_buffer[16384] 2.4 µs 2.7 µs -11.62%

@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

❌ Patch coverage is 67.78711% with 115 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.46%. Comparing base (6b80f3a) to head (9eebdc5).
⚠️ Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-compute/src/logical/and_kleene.rs 47.82% 36 Missing ⚠️
vortex-compute/src/logical/or_kleene.rs 47.82% 36 Missing ⚠️
vortex-compute/src/filter/bitbuffer.rs 75.00% 9 Missing ⚠️
vortex-compute/src/filter/mask.rs 0.00% 9 Missing ⚠️
vortex-compute/src/logical/not.rs 68.00% 8 Missing ⚠️
vortex-vector/src/bool/vector_mut.rs 0.00% 7 Missing ⚠️
vortex-buffer/src/bit/ops.rs 78.26% 5 Missing ⚠️
vortex-compute/src/filter/bool.rs 0.00% 3 Missing ⚠️
vortex-compute/src/filter/buffer.rs 95.83% 2 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn requested review from a10y and robert3005 and removed request for robert3005 October 23, 2025 20:57
@gatesn gatesn merged commit 180a8b9 into develop Oct 23, 2025
38 of 39 checks passed
@gatesn gatesn deleted the ngates/vortex-compute branch October 23, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Release label indicating a new feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants