Skip to content

Conversation

@connortsui20
Copy link
Contributor

It incorrectly assumed that the upper bound for iterators is true.

Also adds a set_len method.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 23, 2025

CodSpeed Performance Report

Merging #5056 will degrade performances by 18.21%

Comparing ct/from-iter-bits (9781fc0) with develop (469b801)

Summary

❌ 2 regressions
✅ 1307 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
from_iter[BitBuffer, 16384] 34.9 µs 41.8 µs -16.41%
from_iter[BitBuffer, 65536] 122.8 µs 150.2 µs -18.21%

@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

❌ Patch coverage is 82.22222% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.52%. Comparing base (469b801) to head (9781fc0).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-buffer/src/bit/buf_mut.rs 82.22% 8 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@connortsui20
Copy link
Contributor Author

We get a small regression here (likely due to the extra branch) and it also regresses on my macbook, but AFAIK this is the cost of correctness here (and the benchmark is the idealized version where we know the exact length of the iterator anyways)

@connortsui20 connortsui20 mentioned this pull request Oct 23, 2025
It incorrectly assumed that the upper bound for iterators is true.

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@gatesn gatesn merged commit 6b8df0c into develop Oct 23, 2025
40 of 41 checks passed
@gatesn gatesn deleted the ct/from-iter-bits branch October 23, 2025 20:32
@connortsui20 connortsui20 mentioned this pull request Oct 24, 2025
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants