Skip to content

Conversation

@0ax1
Copy link
Contributor

@0ax1 0ax1 commented Oct 24, 2025

No description provided.

@0ax1 0ax1 added the do not merge Pull requests that are not intended to merge label Oct 24, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 24, 2025

CodSpeed Performance Report

Merging #5065 will improve performances by ×3.1

Comparing ad/alp-fuse (acc8256) with develop (28f5b3d)1

Summary

⚡ 36 improvements
✅ 1282 untouched
🆕 7 new
⏩ 155 skipped2

Benchmarks breakdown

Benchmark BASE HEAD Change
decompress_alp[f32, (1000, 0.0, 0.25)] 12.1 µs 8.8 µs +37.7%
decompress_alp[f32, (1000, 0.0, 0.95)] 12.1 µs 8.8 µs +37.24%
decompress_alp[f32, (1000, 0.0, 1.0)] 11.5 µs 8.7 µs +31.06%
decompress_alp[f32, (1000, 0.01, 0.25)] 26.4 µs 11.9 µs ×2.2
decompress_alp[f32, (1000, 0.01, 0.95)] 26 µs 11.7 µs ×2.2
decompress_alp[f32, (1000, 0.01, 1.0)] 15.1 µs 11.5 µs +31.66%
decompress_alp[f32, (1000, 0.1, 0.25)] 26.2 µs 11.8 µs ×2.2
decompress_alp[f32, (1000, 0.1, 0.95)] 28.2 µs 13.4 µs ×2.1
decompress_alp[f32, (1000, 0.1, 1.0)] 16.2 µs 12.6 µs +27.8%
decompress_alp[f32, (10000, 0.0, 0.25)] 81.2 µs 27.5 µs ×3
decompress_alp[f32, (10000, 0.0, 0.95)] 81.1 µs 27.5 µs ×3
decompress_alp[f32, (10000, 0.0, 1.0)] 81 µs 27.4 µs ×3
decompress_alp[f32, (10000, 0.01, 0.25)] 97.2 µs 30.9 µs ×3.1
decompress_alp[f32, (10000, 0.01, 0.95)] 98.6 µs 31.5 µs ×3.1
decompress_alp[f32, (10000, 0.01, 1.0)] 85.7 µs 32.3 µs ×2.7
decompress_alp[f32, (10000, 0.1, 0.25)] 102.3 µs 34.2 µs ×3
decompress_alp[f32, (10000, 0.1, 0.95)] 119 µs 40.7 µs ×2.9
decompress_alp[f32, (10000, 0.1, 1.0)] 95.4 µs 40.9 µs ×2.3
decompress_alp[f64, (1000, 0.0, 0.25)] 16.8 µs 11.6 µs +45.46%
decompress_alp[f64, (1000, 0.0, 0.95)] 16.7 µs 11.7 µs +42.22%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Footnotes

  1. No successful run was found on develop (72bd594) during the generation of this report, so 28f5b3d was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 155 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

❌ Patch coverage is 89.71963% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.88%. Comparing base (28f5b3d) to head (e8fa76a).
⚠️ Report is 8 commits behind head on develop.

Files with missing lines Patch % Lines
encodings/alp/src/alp/compress.rs 87.84% 22 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joseph-isaacs
Copy link
Contributor

joseph-isaacs commented Oct 24, 2025

I added some e2e decompression. #5067

Might be nice to see numbers go down

@0ax1 0ax1 force-pushed the ad/alp-fuse branch 2 times, most recently from a49ef6e to a73a0e1 Compare October 24, 2025 14:34
@0ax1 0ax1 changed the title experiment: fused patches alp decompression feat: fuse alp decode with applying patches Oct 24, 2025
@0ax1 0ax1 added feature Release label indicating a new feature or request performance Release label indicating an improvement to performance and removed feature Release label indicating a new feature or request do not merge Pull requests that are not intended to merge labels Oct 24, 2025
@0ax1 0ax1 changed the title feat: fuse alp decode with applying patches perf: fuse alp decode with applying patches Oct 24, 2025
@0ax1 0ax1 requested a review from robert3005 October 24, 2025 14:35
@0ax1 0ax1 marked this pull request as ready for review October 24, 2025 14:36
@0ax1 0ax1 force-pushed the ad/alp-fuse branch 2 times, most recently from b1de611 to f35542d Compare October 24, 2025 14:47
@0ax1 0ax1 force-pushed the ad/alp-fuse branch 4 times, most recently from b3f896d to 1c73f16 Compare November 5, 2025 15:30
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
0ax1 added 2 commits November 5, 2025 16:35
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
@0ax1 0ax1 enabled auto-merge (squash) November 5, 2025 16:52
robert3005 and others added 3 commits November 5, 2025 17:20
Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
@cloudflare-workers-and-pages
Copy link

Deploying vortex-bench with  Cloudflare Pages  Cloudflare Pages

Latest commit: acc8256
Status: ✅  Deploy successful!
Preview URL: https://18e26793.vortex-93b.pages.dev
Branch Preview URL: https://ad-alp-fuse.vortex-93b.pages.dev

View logs

@0ax1 0ax1 merged commit 7c0977a into develop Nov 5, 2025
62 of 76 checks passed
@0ax1 0ax1 deleted the ad/alp-fuse branch November 5, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance Release label indicating an improvement to performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants