Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions encodings/alp/src/alp/compress.rs
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ where
{
let values_slice = values.as_slice::<T>();

let (exponents, encoded, exceptional_positions, exceptional_values, chunk_offsets) =
let (exponents, encoded, exceptional_positions, exceptional_values, mut chunk_offsets) =
T::encode(values_slice, exponents);

let encoded_array = PrimitiveArray::new(encoded, values.validity().clone()).into_array();
Expand All @@ -82,7 +82,16 @@ where
let (pos, vals): (BufferMut<u64>, BufferMut<T>) = exceptional_positions
.into_iter()
.zip_eq(exceptional_values)
.filter(|(index, _)| is_valid.value(*index as usize))
.filter(|(index, _)| {
let is_valid = is_valid.value(*index as usize);
if !is_valid {
let patch_chunk = *index as usize / 1024;
for chunk_idx in (patch_chunk + 1)..chunk_offsets.len() {
chunk_offsets[chunk_idx] -= 1;
}
}
is_valid
})
.unzip();
(pos.freeze(), vals.freeze())
}
Expand Down
4 changes: 2 additions & 2 deletions encodings/alp/src/alp/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ pub trait ALPFloat: private::Sealed + Float + Display + NativePType {
Buffer<Self::ALPInt>,
Buffer<u64>,
Buffer<Self>,
Buffer<u64>,
BufferMut<u64>,
) {
let exp = exponents.unwrap_or_else(|| Self::find_best_exponents(values));

Expand Down Expand Up @@ -158,7 +158,7 @@ pub trait ALPFloat: private::Sealed + Float + Display + NativePType {
encoded_output.freeze(),
patch_indices.freeze(),
patch_values.freeze(),
chunk_offsets.freeze(),
chunk_offsets,
)
}

Expand Down
Loading