Skip to content

perf[btrblocks]: write list (not list view). #5087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joseph-isaacs merged 2 commits into from
Oct 27, 2025
Merged

perf[btrblocks]: write list (not list view). #5087

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5a52ca
perf[btrblocks]: write list (not list view).
joseph-isaacs Oct 27, 2025
a30a9d6
perf[btrblocks]: write list (not list view).
joseph-isaacs Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 9 additions & 16 deletions vortex-btrblocks/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ use std::fmt::Debug;
use std::hash::Hash;

use vortex_array::arrays::{
ExtensionArray, FixedSizeListArray, ListViewArray, StructArray, TemporalArray,
ExtensionArray, FixedSizeListArray, ListArray, StructArray, TemporalArray, list_from_list_view,
};
use vortex_array::vtable::{VTable, ValidityHelper};
use vortex_array::{Array, ArrayRef, Canonical, IntoArray, ToCanonical};
Expand Down Expand Up @@ -398,33 +398,26 @@ impl BtrBlocksCompressor {
)?
.into_array())
}
Canonical::List(list_array) => {
// Compress the inner elements.
Canonical::List(list_view_array) => {
// TODO(joe): We might want to write list views in the future and chose between
// list and list view.
let list_array = list_from_list_view(list_view_array);

let compressed_elems = self.compress(list_array.elements())?;

// Note that since the type of our offsets and sizes is not encoded in our `DType`,
// we can narrow the widths.
// Note that since the type of our offsets are not encoded in our `DType`,
// we may narrow the widths.

// Compress the offsets.
let compressed_offsets = IntCompressor::compress_no_dict(
&list_array.offsets().to_primitive().narrow()?,
false,
MAX_CASCADE,
&[],
)?;

// Compress the sizes.
let compressed_sizes = IntCompressor::compress_no_dict(
&list_array.sizes().to_primitive().narrow()?,
false,
MAX_CASCADE,
&[],
)?;

Ok(ListViewArray::try_new(
Ok(ListArray::try_new(
compressed_elems,
compressed_offsets,
compressed_sizes,
list_array.validity().clone(),
)?
.into_array())
Expand Down
Loading