-
Notifications
You must be signed in to change notification settings - Fork 115
Feature: Struct Vectors #5094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Struct Vectors #5094
Conversation
d9a21de to
a8343c6
Compare
a8343c6 to
1eed89b
Compare
Codecov Report❌ Patch coverage is
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| /// | ||
| /// This is stored here as a convenience, and also helps in the case that the `StructVector` has | ||
| /// no fields. | ||
| pub(super) len: usize, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The length is actually stored in validity, so this isn't necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is nice for a convenience. And also while this isn't exactly the same problem, storing length in the validity is what caused Arrow's FixedSizeList to be wrong, so I feel we might as well be explicit to be safe.
gatesn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok fine, let's keep new(), but don't be specific in the vortex_except message, just say "failed to create vector" or similar, the backtrace from the result will contain the actual message.
e939edc to
d5164fc
Compare
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
1d8fb40 to
b4d5826
Compare
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Tracking Issue: #5028
Adds
StructVectorandStructVectorMut.Note: It would be really nice to have something like serde values that we can iterate and take as an iterator to construct these struct vectors, otherwise we are left with what I currently have on this PR, which imo is very unwieldy. This can come in a later PR though.
The second commit fixes some errors and also removes all of the
newfunctions for vectors (as per an offline discussion with @gatesn).