Skip to content

Conversation

@gatesn
Copy link
Contributor

@gatesn gatesn commented Oct 28, 2025

No description provided.

Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn added the feature Release label indicating a new feature or request label Oct 28, 2025
@gatesn gatesn enabled auto-merge (squash) October 28, 2025 21:32
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 28, 2025

CodSpeed Performance Report

Merging #5104 will degrade performances by 32.62%

Comparing ngates/masking (42bdc29) with develop (60ce4b5)1

Summary

⚡ 28 improvements
❌ 18 regressions
✅ 1272 untouched
🆕 7 new
⏩ 29 skipped2

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
decompress_rd[f32, 100000] 943 µs 854.6 µs +10.35%
decompress_rd[f64, 100000] 1.2 ms 1.3 ms -10.07%
decompress_rd[f64, 10000] 153.6 µs 139.5 µs +10.14%
decompress_bitpacking_early_filter[i16, 0.03] 231.3 µs 189.4 µs +22.12%
decompress_bitpacking_early_filter[i16, 0.04] 244 µs 202 µs +20.78%
decompress_bitpacking_early_filter[i16, 0.05] 257.2 µs 215.2 µs +19.48%
decompress_bitpacking_late_filter[i16, 0.0105] 137.8 µs 197.4 µs -30.19%
decompress_bitpacking_late_filter[i16, 0.01] 137.8 µs 197.4 µs -30.22%
decompress_bitpacking_late_filter[i16, 0.02] 152.4 µs 212.1 µs -28.15%
decompress_bitpacking_late_filter[i16, 0.03] 166.4 µs 226 µs -26.38%
decompress_bitpacking_late_filter[i16, 0.04] 179.6 µs 239.2 µs -24.93%
decompress_bitpacking_late_filter[i16, 0.05] 192.8 µs 252.4 µs -23.63%
decompress_bitpacking_late_filter[i32, 0.0105] 298.5 µs 210.5 µs +41.8%
decompress_bitpacking_late_filter[i32, 0.01] 297.8 µs 209.9 µs +41.92%
decompress_bitpacking_late_filter[i32, 0.02] 314.5 µs 226.5 µs +38.87%
decompress_bitpacking_late_filter[i32, 0.03] 329.5 µs 241.5 µs +36.41%
decompress_bitpacking_late_filter[i32, 0.04] 344.1 µs 256.1 µs +34.36%
decompress_bitpacking_late_filter[i32, 0.05] 358.5 µs 270.6 µs +32.5%
decompress_bitpacking_late_filter[i64, 0.0105] 499.5 µs 320.1 µs +56.05%
decompress_bitpacking_late_filter[i64, 0.01] 498.6 µs 319.2 µs +56.17%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Footnotes

  1. No successful run was found on develop (225c3b4) during the generation of this report, so 60ce4b5 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 29 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

❌ Patch coverage is 41.09589% with 86 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.44%. Comparing base (60ce4b5) to head (42bdc29).
⚠️ Report is 10 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-array/src/compute/arrays/is_not_null.rs 52.72% 26 Missing ⚠️
vortex-array/src/compute/arrays/is_null.rs 52.72% 26 Missing ⚠️
vortex-compute/src/mask/mod.rs 0.00% 21 Missing ⚠️
vortex-array/src/arrays/masked/vtable/operator.rs 0.00% 13 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@joseph-isaacs joseph-isaacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arrays are so verbose

@gatesn gatesn merged commit e878bbb into develop Oct 29, 2025
39 of 40 checks passed
@gatesn gatesn deleted the ngates/masking branch October 29, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Release label indicating a new feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants