Skip to content

Conversation

@robert3005
Copy link
Contributor

@robert3005 robert3005 commented Nov 3, 2025

fix #5157

joseph-isaacs and others added 2 commits November 3, 2025 17:36
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 marked this pull request as ready for review November 3, 2025 21:03
@robert3005 robert3005 added the fix label Nov 3, 2025
@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.82%. Comparing base (69ef61d) to head (3487a2c).
⚠️ Report is 18 commits behind head on develop.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gatesn gatesn merged commit 415c40e into develop Nov 4, 2025
40 of 41 checks passed
@gatesn gatesn deleted the rk/fixnullablemaxmin branch November 4, 2025 01:32
@robert3005
Copy link
Contributor Author

robert3005 commented Nov 4, 2025

There's additional edge case that this doesn't handle - all null bool arrays. We will claim they have min/max of false I think entry point will actually cover it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: min/max bool array incorrect

4 participants