Skip to content

Conversation

@gatesn
Copy link
Contributor

@gatesn gatesn commented Nov 21, 2025

Based on the community model of ghostty-org/ghostty#3558

Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn requested a review from robert3005 November 21, 2025 20:01
@gatesn gatesn enabled auto-merge (squash) November 21, 2025 20:02
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 21, 2025

CodSpeed Performance Report

Merging #5456 will degrade performances by 22.77%

Comparing ngates/issue-templates (b0a54de) with develop (5dbe73e)

Summary

⚡ 7 improvements
❌ 7 regressions
✅ 1508 untouched
⏩ 42 skipped1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
batch[1024] 8.5 µs 9.5 µs -10.46%
batch[262144] 1.8 ms 2 ms -11.48%
in_place_batch[1024] 5.3 µs 4.7 µs +13.16%
in_place_batch[16384] 49.1 µs 63.5 µs -22.77%
in_place_batch[8192] 31.8 µs 26.7 µs +19.19%
in_place_pipeline[16384] 23.9 µs 27.2 µs -12.23%
in_place_pipeline[65536] 101.2 µs 85.3 µs +18.63%
in_place_pipeline[86016] 110.9 µs 133 µs -16.58%
pipeline[1024] 8.9 µs 8 µs +11.3%
pipeline[16384] 32 µs 27.9 µs +14.75%
pipeline[65536] 89.3 µs 106.2 µs -15.93%
pipeline[86016] 114.9 µs 136.1 µs -15.56%
pipeline_extra_copy[1024] 8.9 µs 8 µs +10.56%
verify_all_methods[16384] 37.9 ms 23 ms +64.91%

Footnotes

  1. 42 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.95%. Comparing base (aafe376) to head (b0a54de).
⚠️ Report is 11 commits behind head on develop.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn added the chore Release label indicating a trivial change label Nov 21, 2025
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn merged commit 52ee607 into develop Nov 21, 2025
43 of 44 checks passed
@gatesn gatesn deleted the ngates/issue-templates branch November 21, 2025 23:02
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot now create issues?

a10y pushed a commit that referenced this pull request Nov 25, 2025
Based on the community model of
ghostty-org/ghostty#3558

---------

Signed-off-by: Nicholas Gates <nick@nickgates.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Release label indicating a trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants