Skip to content

Conversation

@connortsui20
Copy link
Contributor

Pulls out the modified-for-operatoras apply patches implementation as a method on Patches instead.

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20 connortsui20 requested a review from gatesn November 21, 2025 22:01
@connortsui20 connortsui20 added the chore Release label indicating a trivial change label Nov 21, 2025
@connortsui20 connortsui20 enabled auto-merge (squash) November 21, 2025 22:06
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 21, 2025

CodSpeed Performance Report

Merging #5458 will degrade performances by 34.55%

Comparing ct/apply-patches (b5285bb) with develop (5dbe73e)

Summary

⚡ 5 improvements
❌ 9 regressions
✅ 1501 untouched
🆕 7 new
⏩ 49 skipped1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 decompress[("alp_for_bp_f64", 0x45b98a0)] N/A 29.8 ms N/A
🆕 decompress[("datetime_for_bp", 0x45bc370)] N/A 41.7 ms N/A
🆕 decompress[("dict_fsst_varbin_bp_string", 0x45bb7f0)] N/A 76.3 ms N/A
🆕 decompress[("dict_fsst_varbin_string", 0x45bb470)] N/A 76.3 ms N/A
🆕 decompress[("dict_varbinview_string", 0x45ba2c0)] N/A 75.6 ms N/A
🆕 decompress[("for_bp_u64", 0x45b9150)] N/A 2.5 ms N/A
🆕 decompress[("runend_for_bp_u32", 0x45ba650)] N/A 2.1 ms N/A
batch[100352] 772.9 µs 658.6 µs +17.36%
batch[262144] 1.8 ms 2 ms -11.48%
in_place_batch[100352] 318.3 µs 381.2 µs -16.5%
in_place_batch[16384] 49.1 µs 63.6 µs -22.8%
in_place_batch[65536] 249.4 µs 208.4 µs +19.67%
in_place_pipeline[16384] 23.9 µs 27.2 µs -12.32%
in_place_pipeline[86016] 110.9 µs 133 µs -16.6%
pipeline[100352] 132.9 µs 157.7 µs -15.74%
pipeline[65536] 89.3 µs 106.1 µs -15.88%
pipeline[86016] 114.9 µs 136.1 µs -15.54%
pipeline_extra_copy[262144] 402.4 µs 334.3 µs +20.36%
pipeline_extra_copy[73728] 118.5 µs 99.6 µs +19.01%
verify_all_methods[1024] 315.2 µs 481.6 µs -34.55%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Footnotes

  1. 49 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@connortsui20 connortsui20 merged commit d2e6eb2 into develop Nov 21, 2025
45 of 46 checks passed
@connortsui20 connortsui20 deleted the ct/apply-patches branch November 21, 2025 22:12
@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.94%. Comparing base (5dbe73e) to head (b5285bb).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-array/src/patches.rs 72.88% 16 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

a10y pushed a commit that referenced this pull request Nov 25, 2025
Pulls out the modified-for-operatoras apply patches implementation as a
method on `Patches` instead.

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Release label indicating a trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants