Skip to content

perf[layout]: apply then filter #5788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joseph-isaacs merged 1 commit into from
Dec 18, 2025
Merged

perf[layout]: apply then filter #5788

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions vortex-layout/src/layouts/flat/reader.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,9 +158,11 @@ impl LayoutReader for FlatReader {

let array_mask = if *USE_VORTEX_OPERATORS {
if mask.density() < FILTER_OF_FILTER_THRESHOLD {
// Run only over the pre-filtered rows.
let array = array.filter(mask.clone())?;
// We have the choice to apply the filter or the expression first, we apply the
// expression first so that it can try pushing down itself and then the filter
// after this.
let array = array.apply(&expr)?;
let array = array.filter(mask.clone())?;
let array_mask = array.execute_mask(&session)?;

mask.intersect_by_rank(&array_mask)
Expand Down
Loading