Update the build intrsuctions #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…red version specified with the 's' in (eclipse-paho-mqtt-c::paho-mqtt3a)s(-static) README.md: added a build option to build paho-mqtt-c library in secure mode
Updated README.md to fit the changed CMakeLists.txt
Updated CMakeLists.txt to fit the changed README.md
|
Thanks for your help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I tested the build instructions on my Ubuntu server computer, it failed to build.
I realized that the paho-mqtt-c build process was unusual, and I found how to make it work on my computer.
So I propose here some build instructions compatible with Ubuntu, and most probably it should be compatible with any Linux distribution. CMakeLists.txt has been simplified and include and library dirs have been explicitely mentionned.
However, as I don't know at all ESP32 NodeMcu, I have no idea whether those new instructions are compatible. And even how to build/compile. I made it clear in the README that the build instructions were tested on two Ubuntu computers.
If something was done the wrong way, I apologize in advance and ask you to share with me your comments, so that I fix what I can.