Refine Package Discovery in Setup Script #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses an issue with the package discovery process in the setup script. Previously, the `find_packages` function from `setuptools` was used with an exclusion filter for the 'tests' directory. However, this approach did not account for the specific structure of our project, potentially leading to some packages being overlooked or incorrectly included. Changes made: - Modified the `find_packages` call to explicitly include the main package 'dnsvalidator' and all its sub-packages. This ensures that the setup script correctly locates and includes all necessary packages within the 'dnsvalidator' directory, aligning with our project's directory structure. This modification aims at enhancing the reliability and accuracy of the package setup process, ensuring a smoother installation and deployment experience for users and contributors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses an issue with the package discovery process in the setup script. Previously, the
find_packagesfunction fromsetuptoolswas used with an exclusion filter for the 'tests' directory. However, this approach did not account for the specific structure of our project, potentially leading to some packages being overlooked or incorrectly included.Changes made:
find_packagescall to explicitly include the main package 'dnsvalidator' and all its sub-packages. This ensures that the setup script correctly locates and includes all necessary packages within the 'dnsvalidator' directory, aligning with our project's directory structure.This modification aims at enhancing the reliability and accuracy of the package setup process, ensuring a smoother installation and deployment experience for users and contributors.