Skip to content

Conversation

@dariosb
Copy link
Member

@dariosb dariosb commented Jul 30, 2020

git submodule add -- /url/of/sub1/repo sub1
On the other hand, AWS Freertos repo is too big and gets too much time updating when first time download.
This wait would be propagated to RKH repo cloning when synching submodules....
Optionally, only get freertos/freertos_kernel repo as submodule may be better.

Adds BOARD environment variable definition for Debug_EDU_CIAA-NXP and Debug_CIAA-NXP builds.

dariosb referenced this pull request Jul 30, 2020
> Created debug configurations (and launchers) for each platform.
> Simplified options to use OpenOCD FreeRTOS integration and semihosting in any case.
> Left a "legacy" configuration as a temporary backup.
@cmancon
Copy link
Collaborator

cmancon commented Jul 30, 2020

I'm up for changing the submodule to the kernel only. What do you think about it @leanfrancucci ?

@cmancon
Copy link
Collaborator

cmancon commented Jul 30, 2020

Changed the submodule to the kernel-only version to evaluate the impact.

The result of the cloning is around 103Mb in objects:

$ git submodule add https://github.com/FreeRTOS/FreeRTOS-Kernel.git third-party/freertos/freertos_kernel
Cloning into '/home/cmancon/RKH/third-party/freertos/freertos_kernel'...
remote: Enumerating objects: 148185, done.
remote: Total 148185 (delta 0), reused 0 (delta 0), pack-reused 148185
Receiving objects: 100% (148185/148185), 102.95 MiB | 3.46 MiB/s, done.
Resolving deltas: 100% (107371/107371), done.

Also, I've checked that the environment variables are being tracked, and had success compiling with each build configurations (Debug_EDU_CIAA-NXP and Debug_CIAA-NXP).

@leanfrancucci
Copy link
Member

I'm up for changing the submodule to the kernel only. What do you think about it @leanfrancucci ?

I agree with that. A submodule is only downloaded when you need it, so when one clone RKH repo there is no need to download all associated submodules as well.

@cmancon
Copy link
Collaborator

cmancon commented Aug 19, 2020

All parties agree then!
@dariosb is there any other commit to include to this PR? I've none. I think we are good to proceed with the closing and merge.

@cmancon cmancon mentioned this pull request Aug 19, 2020
> Before implementing the tact switch (or digital inputs depending the specific platform) bsp_timeTick() was only used by the trace output. For that reason, the implementation was inside a conditional compilation block.
   When the previously said functionality was implemented, the corresponding section of the bsp_timeTick() function was modified to be conditionally compiled but  it wasn't noticed the the entire function was inside a conditional block itself.
   This situation is corrected here and will correctly compile if the trace functionality is disabled.
@cmancon
Copy link
Collaborator

cmancon commented Aug 31, 2020

Added a commit to correct a possible compilation error. It wasn't specific to this branch but this is the more developed one.

@cmancon
Copy link
Collaborator

cmancon commented Sep 16, 2020

I'm thinking in merge this PR in 24hs if none of you have any complain or concern to raise, @dariosb, @leanfrancucci .

@dariosb
Copy link
Member Author

dariosb commented Sep 18, 2020

Its ok for me

@cmancon cmancon merged commit ed6a9c7 into issue-freertos-port Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants