validate Batch Inventory Worksheet uploaded to ballot manifest #2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshen0
force-pushed
the
kevin/error-when-batch-inventory-sheet-uploaded-for-ballot-manifest
branch
2 times, most recently
from
7043903 to
5c8dfd2
Compare
jonahkagan
reviewed
Oct 29, 2024
server/api/ballot_manifest.py
Outdated
| validate_csv_mimetype(request.files["manifest"]) | ||
| file = request.files["manifest"] | ||
| validate_is_not_batch_inventory_worksheet(file) | ||
| validate_csv_mimetype(file) |
There was a problem hiding this comment.
Note that because CSV validation currently happens in upload before process(), it's easiest to trigger a toast notification rather than permanent job error under the upload field.
This doesn't match my reading. I see CSV mimetype validation happening during the initial file upload, but the actual parsing of the CSV file seems to happen within the background task.
If possible, making this a file processing error would be best since it will be persistent in the UI.
There was a problem hiding this comment.
You are absolutely right, sorry! Updated
jonahkagan
approved these changes
Oct 29, 2024
kshen0
force-pushed
the
kevin/error-when-batch-inventory-sheet-uploaded-for-ballot-manifest
branch
from
945445b to
dceec1e
Compare
kshen0
deleted the
kevin/error-when-batch-inventory-sheet-uploaded-for-ballot-manifest
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1946
Returns a more specific error message when a Batch Inventory Worksheet is uploaded instead of ballot manifest.
Note that because CSV validation currently happens in upload before
process(), it's easiest to trigger a toast notification rather than permanent job error under the upload field.Screen.Recording.2024-10-30.at.4.11.13.PM.mov