This repository has been archived by the owner on Nov 3, 2020. It is now read-only.
Tally report #747
Merged
Tally report #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for vw-bmd ready! Built with commit 2e6064c |
beausmith
force-pushed
the
tally-report
branch
2 times, most recently
from
1559d86 to
57be16e
Compare
beausmith
force-pushed
the
tally-report
branch
4 times, most recently
from
ed83441 to
da9b82c
Compare
beausmith
force-pushed
the
tally-report
branch
from
da9b82c to
07e15d7
Compare
beausmith
force-pushed
the
tally-report
branch
2 times, most recently
from
bc592ca to
8c3f8f7
Compare
Merged
beausmith
force-pushed
the
tally-report
branch
3 times, most recently
from
1a52cc8 to
b05c941
Compare
benadida
approved these changes
Oct 2, 2019
|
All @benadida's feedback has been addressed/fixed. Awaiting @eventualbuddha review. |
beausmith
force-pushed
the
tally-report
branch
from
b3e4aa8 to
d113295
Compare
|
@eventualbuddha - If you're happy with this PR, please feel free to merge it. |
eventualbuddha
approved these changes
Oct 7, 2019
This changes the types for the candidate and yesno tallies from arrays into objects. For candidate contests, it splits the former single array that contained both write-ins and ballot candidates into separate properties on an object. For yesno contests, instead of a 2-element tuple we now have an object with "yes" and "no" properties. I think this is simpler and requires less casting. It also adds a few assertions for situations which shouldn't happen but otherwise might silently fail.
This was incorrectly removed by eslint-plugin-react v7.15.x due to a bug. It's been fixed in jsx-eslint/eslint-plugin-react#2437, so this commit updates eslint-plugin-react and re-adds the whitespace.
eventualbuddha
force-pushed
the
tally-report
branch
from
ee3a066 to
2e6064c
Compare
Will do. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks:
Fixes #737