#234 splitCookie needn't be public

vouch · Apr 8, 2020 · 6e5a6c9 · 6e5a6c9
1 parent 6ad7357
commit 6e5a6c9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/pkg/cookie/cookie.go b/pkg/cookie/cookie.go
@@ -49,7 +49,7 @@ func setCookie(w http.ResponseWriter, r *http.Request, val string, maxAge int) {
 	if cookieSize > maxCookieSize {
 		// https://www.lifewire.com/cookie-limit-per-domain-3466809
 		log.Warnf("cookie size: %d.  cookie sizes over ~4093 bytes(depending on the browser and platform) have shown to cause issues or simply aren't supported.", cookieSize)
-		cookieParts := SplitCookie(val, maxCookieSize-emptyCookieSize)
+		cookieParts := splitCookie(val, maxCookieSize-emptyCookieSize)
 		for i, cookiePart := range cookieParts {
 			// Cookies are named 1of3, 2of3, 3of3
 			cookieName = fmt.Sprintf("%s_%dof%d", cfg.Cfg.Cookie.Name, i+1, len(cookieParts))
@@ -152,8 +152,8 @@ func ClearCookie(w http.ResponseWriter, r *http.Request) {
 	}
 }
 
-// SplitCookie separate string into several strings of specified length
-func SplitCookie(longString string, maxLen int) []string {
+// splitCookie separate string into several strings of specified length
+func splitCookie(longString string, maxLen int) []string {
 	splits := make([]string, 0)
 
 	var l, r int

diff --git a/pkg/cookie/cookie_test.go b/pkg/cookie/cookie_test.go
@@ -9,7 +9,7 @@ import (
 	"github.com/vouch/vouch-proxy/pkg/cfg"
 )
 
-func TestSplitCookie(t *testing.T) {
+func TestsplitCookie(t *testing.T) {
 	type args struct {
 		longString string
 		maxLen     int
@@ -23,8 +23,8 @@ func TestSplitCookie(t *testing.T) {
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			if got := SplitCookie(tt.args.longString, tt.args.maxLen); !reflect.DeepEqual(got, tt.want) {
-				t.Errorf("SplitCookie() = %v, want %v", got, tt.want)
+			if got := splitCookie(tt.args.longString, tt.args.maxLen); !reflect.DeepEqual(got, tt.want) {
+				t.Errorf("splitCookie() = %v, want %v", got, tt.want)
 			}
 		})
 	}