Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OIDC Discovery support? #41

Open
mikebryant opened this issue Nov 7, 2018 · 4 comments
Open

OIDC Discovery support? #41

mikebryant opened this issue Nov 7, 2018 · 4 comments

Comments

@mikebryant
Copy link

Instead of setting all the URLs individually, can we use OIDC discovery?

e.g. specify server url and then use /.well-known/openid-configuration

@mikebryant
Copy link
Author

@bnfinet
Copy link
Member

bnfinet commented Nov 8, 2018

Seems like a good idea. There's certainly broad support...

though not Github of Github Enterprise
https://stackoverflow.com/questions/52157568/what-is-github-well-known-openid-configuration-url

I'd probably use the coreos/go-oidc library which assumes /.well-known/openid-configuration [4]

Is that a safe assumption? Even though its part of the spec would you want to override it? I suppose if you're overriding the spec you're fine with setting the endpoints manually.

[1] https://auth0.com/docs/protocols/oidc/openid-connect-discovery
[2] https://www.keycloak.org/docs/3.3/server_admin/topics/identity-broker/oidc.html
[3] https://developer.okta.com/docs/api/resources/oidc#well-knownopenid-configuration
[4] https://github.com/coreos/go-oidc/blob/8ae1da518bd4d9d5a5909090a184af30f336436d/oidc.go#L92-L97

@big-kahuna-burger
Copy link

big-kahuna-burger commented Dec 31, 2018

It's not overriding the spec.
Its just using 1 endpoint to get what is configured with 3 values in config instead. Less error prone.

@rhansen
Copy link

rhansen commented Aug 11, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants