-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to pass tokens #104
Conversation
Add headers for accesstoken and idtoken.
@artagel did you mean to close the PR or is that GitHub being too smart for us. Sorry for the delay in reviewing. |
/sigh.. no :) |
:) |
Implement goreportcard recommendations.
Implement upstream repo changes.
Split cookies
I am looking forward to get this feature. This is useful for securing services running in https://cloud.google.com/run/ that currently needs a header with a JWT. |
Thanks for the PR @artagel |
@karthikv2k have you confirmed that the PR works well for that config? If not, would you be in a position to test that? |
@bnfinet I tested by running vouch proxy locally and connecting it a cloud run service and it works :) Next step is to run the vouch proxy itself as a cloud run service and test. I will get that done by tomorrow. |
@bnfinet I tested this PR in cloud run (as described in my prev comment) and it works. |
Thanks so much for doing that @karthikv2k Much appreciated! |
https://github.com/karthikv2k/oauth_reverse_proxy has the config to work with cloud run. |
…ons for all providers.
…e to jwt functions.
…) specifically allows setting of 'authorized' clients, without this setting the client_secret is not needed. ADFS also only requires client_secret for server applications, and other clients do not need it, and error if they receive it.
…agel/vouch-proxy into artagel-general_fixes_and_unit_testing
…/vouch-proxy into artagel-add_support_to_pass_tokens
@karthikv2k can you please test the branch we're getting closer to full merge :) |
@bnfinet, I am able to test artagel-add_support_to_pass_tokens and it works as expected. Updated the setup details in https://github.com/karthikv2k/oauth_reverse_proxy |
Much appreciated!
I'm traveling through tomorrow and will look again when I've returned.
…On Mon, May 6, 2019, 1:46 PM Karthik Ramasamy ***@***.***> wrote:
@bnfinet <https://github.com/bnfinet>, I am able to test
artagel-add_support_to_pass_tokens and it works as expected. Updated the
setup details in https://github.com/karthikv2k/oauth_reverse_proxy
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#104 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJUV23YYSRPPP2EN2CDZUDPUCKLBANCNFSM4HF2ZB6Q>
.
|
I believe this fixes #74, by adding the support to pass tokens to downstream apps.
Fixes #43
I also believe this is a more complete implementation of #71, which was focused on ADFS. This works for all providers.