-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add env var support #134
Add env var support #134
Conversation
thanks for starting this effort @napcae Will you be able to put more effort into this branch? |
Hey @bnfinet, yes I'm willing to but I have a problem understanding how/why the oath key is not read by viper. I asked in IRC but there was no answer thats why there are no new pushes so far. |
as discussed on IRC we will need to add a |
Yo @bnfinet, any update? |
nope, haven't looked at it yet. I'm devoted to another project this week and then I'm off to a conference. Next week looks a bit better. |
Thanks for the contribution @napcae and sorry for the delay in reviewing. Regarding this direction from the README: I think that... It should "just work". If you set an Environmental Variable that conforms to the naming convention, then you're done. This will save much effort for those using Docker Containers since you won't need to map in any config. Even if a config is available and is successfully read I feel that the environmental variable should override.
A log WARN message of some sort should be printed if the config changes (test the config before and after the env load event) Thanks again and do let me know your thoughts. |
Addresses #132