Treat slice claim values with higher priority before treating all cla… #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…im values as strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…im values as strings
Hi @bnfinet, as promised, here is the pull request for addressing #200. Note that I have to refactor the init() function in the handlers package a bit (move all the variable initialization logic inside, and make it public so it has to be called explicitly) so I can better control the execution order of package initialization logic in tests. Note that I do have to add an explicit call to handlers.Init() in the main() function as a result of this change.
Given that refactoring of this nature is always a little risky, I have briefly tested this change out in my environment and vouch-proxy seems to be working ok (at least not crashing...).