Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nextcloud provider support #218

Merged
merged 3 commits into from
Mar 16, 2020
Merged

Conversation

Dobli
Copy link
Contributor

@Dobli Dobli commented Feb 22, 2020

Nextcloud provides an OAuth2 API to leverage the built in user management (see here). Problem is, they don't provide a proper oauth user endpoint, but it is possible to use the ocs API instead (see here) in json mode.

This needs dedicated handling to extract the proper user info as with other providers. Therefore I added it as an additional provider. I also added an example config with the usual paths of the the auth, token and user urls.

@bnfinet
Copy link
Member

bnfinet commented Mar 12, 2020

@Dobli thanks for the contribution

With #205 going in we've split out the provider specific items into separate packages and files. Could you please rebase and follow the same convention for your nextcloud work? I'll be happy to merge after that.

@bnfinet
Copy link
Member

bnfinet commented Mar 12, 2020

and please do update the README with an entry for nextcloud :)

@Dobli Dobli force-pushed the feature/nextcloud_support branch from 29d49f6 to 8d685ce Compare March 12, 2020 22:02
@Dobli Dobli force-pushed the feature/nextcloud_support branch from 8d685ce to 3e51f1b Compare March 12, 2020 22:24
@Dobli
Copy link
Contributor Author

Dobli commented Mar 12, 2020

done ;)

@bnfinet bnfinet merged commit 3e51f1b into vouch:master Mar 16, 2020
@bnfinet
Copy link
Member

bnfinet commented Mar 16, 2020

@Dobli thanks again for conrtibuting to VP!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants