Supporting IdPs that only have "sub" claims in UserInfo (continuing #310) #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all IdPs provide a `username` or `email` claim in the UserInfo response.
|
I'm sorry for all the dumb commits and merge conflicts, I shoulda rebased off master, realized the PR I based this off of was outdated. I'm still learning the finer points of go modules. |
|
Saw your remediation of the the jwt library, so I'm not too worried about the WhiteSource CVE. PS: I'm deep in OIDC/OAuth specs nowadays, and the "audience can be a string, or array of strings" is an all-timer crazy decision. Sure, looks a minor thing, just some extra brackets in some json. But I've come across so many implementations of trying to map that laissez faire json to an object and none of them are great. It's a tricky problem to solve! |
|
This is probably horribly out of date now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picking up PR #310
Had to make a couple of fixes to get
go getto work with hcl/printer, and then had to update vegeta. But I built a docker container, ran this against my custom OIDC that only givesubback on UserInfo, and it works like a dream!Tagging @bnfinet, their enthusiasm and kindness made me wanna put in some effort to make this change happen!