Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClientSide types #15

Merged
merged 27 commits into from
Mar 10, 2021
Merged

ClientSide types #15

merged 27 commits into from
Mar 10, 2021

Conversation

pkgacek
Copy link
Contributor

@pkgacek pkgacek commented Jan 14, 2021

I'm still waiting for the informations regarding /publish endpoint. Will update it accordingly

eddyw
eddyw reviewed Jan 14, 2021
View reviewed changes
packages/sdk/src/ClientSide.ts Outdated Show resolved Hide resolved
packages/sdk/src/ClientSide.ts Outdated Show resolved Hide resolved
darekg11
darekg11 requested changes Mar 1, 2021
View reviewed changes
packages/sdk/src/ClientSide.ts Outdated Show resolved Hide resolved
packages/sdk/src/types/ClientSide.ts Outdated Show resolved Hide resolved
packages/sdk/src/ClientSide.ts Outdated Show resolved Hide resolved
packages/sdk/src/ClientSide.ts Show resolved Hide resolved
packages/sdk/src/ClientSide.ts Outdated Show resolved Hide resolved
packages/sdk/src/ClientSide.ts Outdated Show resolved Hide resolved
@pkgacek
Copy link
Contributor Author

pkgacek commented Mar 2, 2021

@darekg11 I've modified toQueryParams function to encode everything

@pkgacek
Copy link
Contributor Author

pkgacek commented Mar 4, 2021

@darekg11 now it's tested properly, sorry about that.

darekg11
darekg11 requested changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@darekg11 darekg11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes:

  • logic errors
  • type errors

packages/sdk/src/ClientSide.ts Show resolved Hide resolved
packages/sdk/src/ClientSide.ts Outdated Show resolved Hide resolved
packages/sdk/src/ClientSide.ts Outdated Show resolved Hide resolved
packages/sdk/src/ClientSide.ts Outdated Show resolved Hide resolved
packages/sdk/src/RequestController.ts Show resolved Hide resolved
packages/sdk/src/types/ClientSide.ts Outdated Show resolved Hide resolved
packages/sdk/src/types/ClientSide.ts Outdated Show resolved Hide resolved
packages/sdk/src/ClientSide.ts Outdated Show resolved Hide resolved
packages/sdk/src/types/ClientSide.ts Outdated Show resolved Hide resolved
packages/sdk/src/ClientSide.ts Outdated Show resolved Hide resolved
@darekg11 darekg11 mentioned this pull request Mar 10, 2021
Merged
@pkgacek
Copy link
Contributor Author

pkgacek commented Mar 10, 2021

Updated

@pkgacek
Copy link
Contributor Author

pkgacek commented Mar 10, 2021

Changes made

@pkgacek
Copy link
Contributor Author

pkgacek commented Mar 10, 2021

Final updates

@darekg11 darekg11 merged commit 0098874 into voucherifyio:main Mar 10, 2021
@github-actions github-actions bot mentioned this pull request Mar 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyw eddyw eddyw left review comments

@darekg11 darekg11 darekg11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pkgacek @eddyw @darekg11