Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consents types #18

Merged
merged 4 commits into from
Jan 19, 2021
Merged

Consents types #18

merged 4 commits into from
Jan 19, 2021

Conversation

pkgacek
Copy link
Contributor

@pkgacek pkgacek commented Jan 14, 2021

No description provided.

darekg11
darekg11 requested changes Jan 18, 2021
View reviewed changes
Copy link
Contributor

@darekg11 darekg11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested in type definitions.

packages/sdk/src/types/Consents.ts Outdated Show resolved Hide resolved
packages/sdk/src/types/Consents.ts Outdated Show resolved Hide resolved
packages/sdk/src/types/Consents.ts Outdated Show resolved Hide resolved
packages/sdk/src/types/Consents.ts Outdated Show resolved Hide resolved
packages/sdk/src/types/Consents.ts Outdated Show resolved Hide resolved
packages/sdk/src/types/Consents.ts Outdated Show resolved Hide resolved
packages/sdk/src/types/Consents.ts Outdated Show resolved Hide resolved
packages/sdk/src/types/Consents.ts Outdated Show resolved Hide resolved
packages/sdk/src/types/Consents.ts Outdated Show resolved Hide resolved
packages/sdk/src/types/Consents.ts Outdated Show resolved Hide resolved
@pkgacek pkgacek requested a review from darekg11 January 18, 2021 15:36
darekg11
darekg11 approved these changes Jan 19, 2021
View reviewed changes
Copy link
Contributor

@darekg11 darekg11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, merging.

@darekg11 darekg11 merged commit 4d01aad into voucherifyio:main Jan 19, 2021
@github-actions github-actions bot mentioned this pull request Jan 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darekg11 darekg11 darekg11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pkgacek @darekg11