Vouchers types #33
Vouchers types #33
Conversation
|
Vouchers updated - as talked about with @darekg11 |
|
Hey, I've made requested changes. |
| } | ||
| /** | ||
| * @see https://docs.voucherify.io/reference?utm_source=github&utm_medium=sdk&utm_campaign=acq#list-vouchers | ||
| */ | ||
| public list(params?: $FixMe) { | ||
| return this.client.get('/vouchers', params) | ||
| public list(params: T.VouchersListParams = {}) { |
There was a problem hiding this comment.
This is broken, try following code:
voucherify.vouchers
.list({
created_at: {
after: '2021-01-28T08:00:00Z',
},
})
.then(voucher => {
console.log('OKS: %j', voucher)
})
.catch(error => {
console.log(error)
})
It should list vouchers created only after given date, but it is returning everything. I think this is due to the fact that axios (library used for HTTP Request) is automatically escaping params and it ends up as: "created_at": "{\"after\":\"2021-01-28T08:00:00Z\"}" on server-side.
Please check Axios documentation and try to fix it + check every other place in SDK to see if this is also the case somewhere else
There was a problem hiding this comment.
Yep, the seralization was off.
I had to install Qs library for this to work. I've added paramsSerialize to GET method of RequestController, so it will work with other list methods.
Tommorow morning I will check it with other list methods + I will check if those new methods (bulkUpdate, bulkUpdateMetadata) are working correctly.
|
Changes pushed. I want to wait with testing this seralization - i would like to merge other types and then make those tests (because right now i would need to install this additional Qs package for every branch) |
No description provided.