better group slice support for operators #5575
pr.yml
on: pull_request
Matrix: test / test-python
build
/
changes
33s
build
/
build
2m 29s
lint
/
eslint
56s
test
/
test-app
1m 24s
e2e
/
test-e2e
23m 28s
teams
0s
all-tests
0s
Annotations
11 errors, 23 warnings, and 1 notice
[chromium] › oss/specs/groups/dynamic-groups.spec.ts:70:3 › pcd dynamic group pagination bar:
e2e-pw/src/oss/specs/groups/dynamic-groups.spec.ts#L1
1) [chromium] › oss/specs/groups/dynamic-groups.spec.ts:70:3 › pcd dynamic group pagination bar ──
Test timeout of 60000ms exceeded.
|
[chromium] › oss/specs/groups/dynamic-groups.spec.ts:70:3 › pcd dynamic group pagination bar:
e2e-pw/src/shared/event-utils/index.ts#L16
1) [chromium] › oss/specs/groups/dynamic-groups.spec.ts:70:3 › pcd dynamic group pagination bar ──
Error: page.evaluate: Test timeout of 60000ms exceeded.
at shared/event-utils/index.ts:16
14 |
15 | // note: cannot directly pass function to `evaluate`, which is why we expose it to the `window` object first
> 16 | return this.page.evaluate(
| ^
17 | ({ eventName_, exposedFunctionName_ }) =>
18 | new Promise<void>((resolve) => {
19 | const cb = (e: CustomEvent) => {
at EventUtils.getEventReceivedPromiseForPredicate (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/shared/event-utils/index.ts:16:22)
at UrlPom.pageChange (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/poms/url.ts:40:23)
at GridPom.openNthSample (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/poms/grid/index.ts:55:20)
at GridPom.openFirstSample (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/poms/grid/index.ts:61:17)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/groups/dynamic-groups.spec.ts:79:16
|
[chromium] › oss/specs/groups/dynamic-groups.spec.ts:70:3 › pcd dynamic group pagination bar:
e2e-pw/src/oss/poms/grid/index.ts#L56
1) [chromium] › oss/specs/groups/dynamic-groups.spec.ts:70:3 › pcd dynamic group pagination bar ──
Error: locator.click: Test timeout of 60000ms exceeded.
Call log:
- waiting for getByTestId('fo-grid').getByTestId('looker').first()
- locator resolved to <div tabindex="-1" data-cy="looker" class="_looker_1i9j2_16"></div>
- attempting click action
- waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <div>…</div> from <div id="modal" class="modalon">…</div> subtree intercepts pointer events
- retrying click action, attempt #1
- waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <div>…</div> from <div id="modal" class="modalon">…</div> subtree intercepts pointer events
- retrying click action, attempt #2
- waiting 20ms
- waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <div data-cy="looker3d" class="_loading_1wcd9_1">…</div> from <div id="modal" class="modalon">…</div> subtree intercepts pointer events
- retrying click action, attempt #3
- waiting 100ms
- waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <div data-cy="looker3d" class="_loading_1wcd9_1">…</div> from <div id="modal" class="modalon">…</div> subtree intercepts pointer events
- retrying click action, attempt #4
- waiting 100ms
- waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <div data-cy="looker3d" class="_loading_1wcd9_1">…</div> from <div id="modal" class="modalon">…</div> subtree intercepts pointer events
- retrying click action, attempt #5
- waiting 500ms
- waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <div data-cy="looker3d" class="_loading_1wcd9_1">…</div> from <div id="modal" class="modalon">…</div> subtree intercepts pointer events
- retrying click action, attempt #6
- waiting 500ms
- waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <div data-cy="looker3d" class="_loading_1wcd9_1">…</div> from <div id="modal" class="modalon">…</div> subtree intercepts pointer events
- retrying click action, attempt #7
- waiting 500ms
- waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <div data-cy="looker3d" class="_loading_1wcd9_1">…</div> from <div id="modal" class="modalon">…</div> subtree intercepts pointer events
- retrying click action, attempt #8
- waiting 500ms
- waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <div data-cy="looker3d" class="_loading_1wcd9_1">…</div> from <div id="modal" class="modalon">…</div> subtree intercepts pointer events
- retrying click action, attempt #9
- waiting 500ms
- waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <div data-cy="looker3d" class="_loading_1wcd9_1">…</div> from <div id="modal" class="modalon">…</div> subtree intercepts pointer even
|
[chromium] › oss/specs/groups/dynamic-groups.spec.ts:70:3 › png dynamic group pagination bar:
e2e-pw/src/oss/specs/groups/dynamic-groups.spec.ts#L1
2) [chromium] › oss/specs/groups/dynamic-groups.spec.ts:70:3 › png dynamic group pagination bar ──
Test timeout of 60000ms exceeded.
|
[chromium] › oss/specs/groups/dynamic-groups.spec.ts:70:3 › png dynamic group pagination bar:
e2e-pw/src/oss/poms/grid/index.ts#L56
2) [chromium] › oss/specs/groups/dynamic-groups.spec.ts:70:3 › png dynamic group pagination bar ──
Error: locator.click: Test timeout of 60000ms exceeded.
Call log:
- waiting for getByTestId('fo-grid').getByTestId('looker').first()
- locator resolved to <div tabindex="-1" data-cy="looker" title="Click to expand" class="_looker_1i9j2_16">…</div>
- attempting click action
- waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <div tabindex="-1" data-cy="looker" class="_looker_1i9j2_16">…</div> from <div id="modal" class="modalon">…</div> subtree intercepts pointer events
- retrying click action, attempt #1
- waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <div data-cy="looker-error-info" class="_lookerErrorPage_sfdgp_5">…</div> from <div id="modal" class="modalon">…</div> subtree intercepts pointer events
- retrying click action, attempt #2
- waiting 20ms
- waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <div data-cy="looker-error-info" class="_lookerErrorPage_sfdgp_5">…</div> from <div id="modal" class="modalon">…</div> subtree intercepts pointer events
- retrying click action, attempt #3
- waiting 100ms
- waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <div data-cy="looker-error-info" class="_lookerErrorPage_sfdgp_5">…</div> from <div id="modal" class="modalon">…</div> subtree intercepts pointer events
- retrying click action, attempt #4
- waiting 100ms
- waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <div data-cy="looker-error-info" class="_lookerErrorPage_sfdgp_5">…</div> from <div id="modal" class="modalon">…</div> subtree intercepts pointer events
- retrying click action, attempt #5
- waiting 500ms
- waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <div data-cy="looker-error-info" class="_lookerErrorPage_sfdgp_5">…</div> from <div id="modal" class="modalon">…</div> subtree intercepts pointer events
- retrying click action, attempt #6
- waiting 500ms
- waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <div data-cy="looker-error-info" class="_lookerErrorPage_sfdgp_5">…</div> from <div id="modal" class="modalon">…</div> subtree intercepts pointer events
- retrying click action, attempt #7
- waiting 500ms
- waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <div data-cy="looker-error-info" class="_lookerErrorPage_sfdgp_5">…</div> from <div id="modal" class="modalon">…</div> subtree intercepts pointer events
- retrying click action, attempt #8
- waiting 500ms
- waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <div data-cy="looker-error-info" class="_lookerErrorPage_sfdgp_5">…</div> from <div id="modal" class="modalon">…</div> subtree intercepts pointer events
- retrying click action, attempt #9
- waiting 500ms
- waiting for element to be visible, enabled and sta
|
[chromium] › oss/specs/groups/sparse-groups.spec.ts:96:3 › mp4 second slice:
e2e-pw/src/oss/poms/grid/index.ts#L151
3) [chromium] › oss/specs/groups/sparse-groups.spec.ts:96:3 › mp4 second slice ───────────────────
TimeoutError: page.waitForFunction: Timeout 2000ms exceeded.
at oss/poms/grid/index.ts:151
149 |
150 | async isEntryCountTextEqualTo(text: string) {
> 151 | return this.gridPom.page.waitForFunction(
| ^
152 | (text_) => {
153 | return (
154 | document.querySelector("[data-cy='entry-counts']").textContent ===
at GridAsserter.isEntryCountTextEqualTo (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/poms/grid/index.ts:151:30)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/groups/sparse-groups.spec.ts:103:23
|
[chromium] › oss/specs/groups/sparse-groups.spec.ts:96:3 › png second slice:
e2e-pw/src/oss/poms/grid/index.ts#L151
4) [chromium] › oss/specs/groups/sparse-groups.spec.ts:96:3 › png second slice ───────────────────
TimeoutError: page.waitForFunction: Timeout 2000ms exceeded.
at oss/poms/grid/index.ts:151
149 |
150 | async isEntryCountTextEqualTo(text: string) {
> 151 | return this.gridPom.page.waitForFunction(
| ^
152 | (text_) => {
153 | return (
154 | document.querySelector("[data-cy='entry-counts']").textContent ===
at GridAsserter.isEntryCountTextEqualTo (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/poms/grid/index.ts:151:30)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/groups/sparse-groups.spec.ts:103:23
|
[chromium] › oss/specs/regression-tests/group-video/group-video-label.spec.ts:87:3 › groups video labels › video plays with correct label for each slice:
e2e-pw/src/oss/poms/modal/index.ts#L318
5) [chromium] › oss/specs/regression-tests/group-video/group-video-label.spec.ts:87:3 › groups video labels › video plays with correct label for each slice
Error: expect(received).toBe(expected) // Object.is equality
Expected: "📌 v1"
Received: "📌 v2"
at oss/poms/modal/index.ts:318
316 | const actualTitle = await this.modalPom.modalSamplePluginTitle;
317 | const expectedTitle = pinned ? `📌 ${title}` : title;
> 318 | expect(actualTitle).toBe(expectedTitle);
| ^
319 | }
320 | }
321 |
at ModalAsserter.verifyModalSamplePluginTitle (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/poms/modal/index.ts:318:25)
at checkVideo (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/regression-tests/group-video/group-video-label.spec.ts:98:7)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/regression-tests/group-video/group-video-label.spec.ts:121:5
|
[chromium] › oss/specs/regression-tests/index-page.spec.ts:24:1 › index page:
e2e-pw/src/oss/specs/regression-tests/index-page.spec.ts#L1
6) [chromium] › oss/specs/regression-tests/index-page.spec.ts:24:1 › index page ──────────────────
Test timeout of 60000ms exceeded.
|
[chromium] › oss/specs/regression-tests/index-page.spec.ts:24:1 › index page:
e2e-pw/src/oss/poms/page.ts#L37
6) [chromium] › oss/specs/regression-tests/index-page.spec.ts:24:1 › index page ──────────────────
Error: page.waitForSelector: Test timeout of 60000ms exceeded.
Call log:
- waiting for locator('[data-cy=index-page]') to be visible
at oss/poms/page.ts:37
35 | await this.datasetSelector.selectResult(dataset);
36 | }
> 37 | await this.page.waitForSelector(
| ^
38 | `[data-cy=${dataset ? "dataset" : "index"}-page]`,
39 | {
40 | state: "visible",
at PagePom.loadDataset (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/poms/page.ts:37:21)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/regression-tests/index-page.spec.ts:25:3
|
e2e / test-e2e:
e2e-pw/src/oss/specs/regression-tests/sidebar/sidebar-datetime.spec.ts#L74
'grid' is defined but never used
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L37
React Hook useEffect has missing dependencies: 'panelId' and 'setPanelCloseEffect'. Either include them or remove the dependency array
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L101
React Hook useEffect has a missing dependency: 'dimensions'. Either include it or remove the dependency array
|
lint / eslint:
app/packages/operators/src/built-in-operators.ts#L815
'ctx' is defined but never used. Allowed unused args must match /^_/u
|
lint / eslint
'ctx' is defined but never used. Allowed unused args must match /^_/u
|
lint / eslint
'ctx' is defined but never used. Allowed unused args must match /^_/u
|
lint / eslint
'ctx' is defined but never used. Allowed unused args must match /^_/u
|
lint / eslint
'ctx' is defined but never used. Allowed unused args must match /^_/u
|
lint / eslint
'path' is never reassigned. Use 'const' instead
|
lint / eslint
'value' is never reassigned. Use 'const' instead
|
lint / eslint
'ctx' is defined but never used. Allowed unused args must match /^_/u
|
test / test-python (ubuntu-latest-m, 3.10)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
test / test-python (ubuntu-latest-m, 3.11)
Codecov: Failed to properly create commit: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1
|
test / test-python (ubuntu-latest-m, 3.11)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
test / test-python (ubuntu-latest-m, 3.9)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Slow Test:
e2e-pw/[chromium] › oss/specs/smoke-tests/field-visibility.spec.ts#L1
e2e-pw/[chromium] › oss/specs/smoke-tests/field-visibility.spec.ts took 53.9s
|
Slow Test:
e2e-pw/[chromium] › oss/specs/smoke-tests/saved-views.spec.ts#L1
e2e-pw/[chromium] › oss/specs/smoke-tests/saved-views.spec.ts took 25.4s
|
Slow Test:
e2e-pw/[chromium] › oss/specs/selection.spec.ts#L1
e2e-pw/[chromium] › oss/specs/selection.spec.ts took 18.3s
|
Slow Test:
e2e-pw/[chromium] › oss/specs/sidebar/sidebar.spec.ts#L1
e2e-pw/[chromium] › oss/specs/sidebar/sidebar.spec.ts took 17.5s
|
Slow Test:
e2e-pw/[chromium] › oss/specs/operators/prompt.spec.ts#L1
e2e-pw/[chromium] › oss/specs/operators/prompt.spec.ts took 15.8s
|
e2e / test-e2e
Unexpected input(s) 'working-directory', valid inputs are ['path', 'key', 'restore-keys', 'upload-chunk-size', 'enableCrossOsArchive', 'fail-on-cache-miss', 'lookup-only', 'save-always']
|
e2e / test-e2e
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
e2e / test-e2e:
e2e-pw/src/oss/specs/regression-tests/media-field.spec.ts#L78
Unexpected use of the `.skip()` annotation
|
e2e / test-e2e
Unexpected input(s) 'working-directory', valid inputs are ['path', 'key', 'restore-keys', 'upload-chunk-size', 'enableCrossOsArchive', 'fail-on-cache-miss', 'lookup-only', 'save-always']
|
🎭 Playwright Run Summary
11 flaky
[chromium] › oss/specs/groups/dynamic-groups.spec.ts:70:3 › pcd dynamic group pagination bar ───
[chromium] › oss/specs/groups/dynamic-groups.spec.ts:70:3 › png dynamic group pagination bar ───
[chromium] › oss/specs/groups/sparse-groups.spec.ts:96:3 › mp4 second slice ────────────────────
[chromium] › oss/specs/groups/sparse-groups.spec.ts:96:3 › png second slice ────────────────────
[chromium] › oss/specs/regression-tests/group-video/group-video-label.spec.ts:87:3 › groups video labels › video plays with correct label for each slice
[chromium] › oss/specs/regression-tests/index-page.spec.ts:24:1 › index page ───────────────────
[chromium] › oss/specs/smoke-tests/embeddings.spec.ts:62:3 › embeddings on quickstart dataset › lasso samples work
[chromium] › oss/specs/smoke-tests/quickstart-groups.spec.ts:79:5 › quickstart-groups › modal › navigation works
[chromium] › oss/specs/smoke-tests/quickstart-groups.spec.ts:104:5 › quickstart-groups › modal › group media visibility toggle works
[chromium] › oss/specs/smoke-tests/quickstart-groups.spec.ts:139:3 › quickstart-groups › modal with grid filter
[chromium] › oss/specs/smoke-tests/quickstart.spec.ts:80:3 › quickstart › selection bookmark ───
2 skipped
93 passed (17.1m)
|
Artifacts
Produced during runtime
Name | Size | |
---|---|---|
dist
|
19.7 MB |
|
playwright-report
Expired
|
56.9 MB |
|