close bitmap when looker destroys

voxel51 · Nov 22, 2024 · e5eb5de · e5eb5de
1 parent c869b1c
commit e5eb5de
Show file tree

Hide file tree

Showing 5 changed files with 25 additions and 1 deletion.
diff --git a/app/packages/looker/src/lookers/abstract.ts b/app/packages/looker/src/lookers/abstract.ts
@@ -284,6 +284,11 @@ export abstract class AbstractLooker<
           return;
         }
 
+        if (this.state.destroyed && this.sampleOverlays) {
+          // close all current overlays
+          this.pluckedOverlays.forEach((overlay) => overlay.cleanup?.());
+        }
+
         if (
           !this.state.windowBBox ||
           this.state.destroyed ||

diff --git a/app/packages/looker/src/overlays/base.ts b/app/packages/looker/src/overlays/base.ts
@@ -73,6 +73,7 @@ export interface Overlay<State extends Partial<BaseState>> {
   getPoints(state: Readonly<State>): Coordinates[];
   getSelectData(state: Readonly<State>): SelectData;
   getSizeBytes(): number;
+  cleanup?(): void;
 }
 
 export abstract class CoordinateOverlay<

diff --git a/app/packages/looker/src/overlays/detection.ts b/app/packages/looker/src/overlays/detection.ts
@@ -31,7 +31,6 @@ export default class DetectionOverlay<
 > extends CoordinateOverlay<State, DetectionLabel> {
   private is3D: boolean;
   private labelBoundingBox: BoundingBox;
-  private imageBitmap: ImageBitmap | null = null;
 
   constructor(field, label) {
     super(field, label);
@@ -261,6 +260,13 @@ export default class DetectionOverlay<
     const oh = state.strokeWidth / state.canvasBBox[3];
     return [(bx - ow) * w, (by - oh) * h, (bw + ow * 2) * w, (bh + oh * 2) * h];
   }
+
+  public cleanup(): void {
+    if (this.label.mask?.bitmap) {
+      this.label.mask?.bitmap.close();
+      console.log(">>>cleanup");
+    }
+  }
 }
 
 export const getDetectionPoints = (labels: DetectionLabel[]): Coordinates[] => {

diff --git a/app/packages/looker/src/overlays/heatmap.ts b/app/packages/looker/src/overlays/heatmap.ts
@@ -205,6 +205,12 @@ export default class HeatmapOverlay<State extends BaseState>
   getSizeBytes(): number {
     return sizeBytesEstimate(this.label);
   }
+
+  public cleanup(): void {
+    if (this.label.map?.bitmap) {
+      this.label.map?.bitmap.close();
+    }
+  }
 }
 
 export const getHeatmapPoints = (labels: HeatmapLabel[]): Coordinates[] => {

diff --git a/app/packages/looker/src/overlays/segmentation.ts b/app/packages/looker/src/overlays/segmentation.ts
@@ -260,6 +260,12 @@ export default class SegmentationOverlay<State extends BaseState>
   getSizeBytes(): number {
     return sizeBytesEstimate(this.label);
   }
+
+  public cleanup(): void {
+    if (this.label.mask?.bitmap) {
+      this.label.mask?.bitmap.close();
+    }
+  }
 }
 
 export const getSegmentationPoints = (