-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic label field upgrades #3152
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #3152 +/- ##
============================================
- Coverage 49.18% 15.12% -34.07%
============================================
Files 230 560 +330
Lines 34478 68959 +34481
Branches 325 597 +272
============================================
- Hits 16957 10428 -6529
- Misses 17521 58531 +41010
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
14b3752
to
ea05303
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We discussed offline and I'll be adding some follow-up changes to this PR to omit label fields nested within other label fields.
0d87d38
to
f10aa56
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merging #3152 into release branch
Resolves #3157
Resolves #3183
Resolves #3178
Upgrades the SDK to fully support label fields stored as embedded document fields.
Change log
tag_labels()
,select_labels()
,export()
, anddraw_labels()
automatically detect and properly handle label fields stored within embedded documentsDocument
objects now supportdoc["nested.field"]
key access, which ensures that methods that accept label fields as parameters will gracefully support nested label fieldsExample usage