-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to pyproject.toml package file #4019
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4019 +/- ##
========================================
Coverage 15.98% 15.98%
========================================
Files 732 732
Lines 82054 82054
Branches 1110 1110
========================================
Hits 13115 13115
Misses 68939 68939
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@benjaminpkane appreciate the constant eye toward modernization.
|
These may or may not be related useful references. As to python3.8 requirement, it does not seem so bad since it's only for building from source which doesn't happen so often. We'll still want to float it around a bit before committing though. |
I'd be in favor of officially dropping 3.7 with this change. Still need to fix documentation builds, so leaving it as a draft for now.
|
Closing until the team has more bandwidth |
Building on top of #3821, this PR moves the main
fiftyone
package description from a setup.py file to the now recommended pyproject.toml file.Changes
Hatchling is now used as the build backend for the project. This requires Python 3.8+, so this change will implicitly drop support for Python 3.7 when installing from source
The OpenCV dependency is still dynamically chosen (see
dependencies.py
) when installing from source. See #1494Builds themselves have been improved with the
hatch.toml
file, which is more prescriptive about what files to include. Specifically, the App static files, and documentation recipes and tutorials.Other packages can be transitioned to
pyproject.toml
descriptions if this change is accepted!