Cherry pick #4715

[brimoor]

Cherry-picking #4715 for release.

Benefits: delegated operations will no longer emit spurious "failed to resolve output schema for the operation" warnings (regression in fiftyone==0.25).

Risks: none

[coderabbitai]

Walkthrough

The change introduces a conditional check in the _execute_operator function to verify that the outputs variable is not None before invoking the to_json() method. This adjustment aims to prevent potential AttributeError exceptions and enhances the function's error handling by ensuring that method calls are only made on valid objects.

Changes

Files	Change Summary
fiftyone/operators/delegated.py	Added a conditional check for outputs to ensure it is not None before calling to_json().

Poem

In the meadow, where bunnies play,
A change was made to brighten the day.
No more errors, just smooth, sweet flow,
With checks in place, our code will glow!
Hops of joy, we dance and cheer,
For safer paths, we hold so dear! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1fdd870 and 52cf69a.

Files selected for processing (1)

• fiftyone/operators/delegated.py (1 hunks)

Additional comments not posted (1)

fiftyone/operators/delegated.py (1)

408-409: LGTM!

The conditional check is a good addition that prevents calling to_json() on None, which would raise an AttributeError. This change enhances the error handling and makes the code more robust.

[imanjra]

LGTM

[ritch]

💡

if isinstance(outputs, Property):
    outputs_schema = outputs.to_json()
elif outputs is not None:
    raise InvalidOutput()